Skip to content

Add pytorch_scatter ci run#1748

Merged
h-vetinari merged 5 commits intoconda-forge:mainfrom
mikemhenry:pytorch_scatter_ci_run
Nov 14, 2025
Merged

Add pytorch_scatter ci run#1748
h-vetinari merged 5 commits intoconda-forge:mainfrom
mikemhenry:pytorch_scatter_ci_run

Conversation

@mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Nov 10, 2025 •
edited
Loading

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.

  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.

  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed

  • I want to copy an artifact following CFEP-3:

    • Pinged the relevant feedstock team(s)
    • Added a reference to the original PR
    • Posted a link to the conda artifacts
    • Posted a link to the build logs

  • I want to add a package output to a feedstock:

    • Pinged the relevant feedstock team(s)
    • Added a small description of why the output is being added.

@mikemhenry mikemhenry requested a review from a team as a code owner November 10, 2025 18:40
@mikemhenry
Copy link
Contributor Author

mikemhenry commented Nov 10, 2025

@conda-forge/pytorch_scatter This is for conda-forge/pytorch_scatter-feedstock#74

The new aarch64 builds are hitting the timeout limit, see conda-forge/pytorch_scatter-feedstock#74 (comment)

@mikemhenry mikemhenry mentioned this pull request Nov 10, 2025
Closed
5 tasks
mgorny
mgorny reviewed Nov 10, 2025
View reviewed changes
requests/add-openfe-start-as-output-to-openfe.yml Outdated
@@ -0,0 +1,3 @@
action: add_feedstock_output
Copy link
Contributor

@mgorny mgorny Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems accidental.

Copy link
Contributor Author

@mikemhenry mikemhenry Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! good catch, fixed

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seems to be included?

Copy link
Contributor Author

@mikemhenry mikemhenry Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I didn't pay attention to the file path and just looked at the line number!

requests/pytorch_scatter-cirun.yaml Outdated
Comment on lines 5 to 7
- cirun-openstack-cpu-medium
- cirun-openstack-cpu-large
- cirun-openstack-cpu-xlarge
Copy link
Contributor

@mgorny mgorny Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need all three? oO

Copy link
Contributor Author

@mikemhenry mikemhenry Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! I was thinking I would start with large and see if that works 😎

@mikemhenry
Copy link
Contributor Author

mikemhenry commented Nov 10, 2025

I'll be honest, when I saw that this was "gpu" I didn't think it was applicable to what I was doing, so I just looked at #1746 for inspo.

BUT now looking at that file, it is really clear what I want :)

@Tobias-Fischer
Copy link
Contributor

Tobias-Fischer commented Nov 12, 2025

Hi @h-vetinari @wolfv - could you please take a look?

many thanks!

@h-vetinari h-vetinari merged commit 21a438a into conda-forge:main Nov 14, 2025
1 check passed
This was referenced Nov 14, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

+2 more reviewers

@mgorny mgorny mgorny left review comments

@Tobias-Fischer Tobias-Fischer Tobias-Fischer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikemhenry @Tobias-Fischer @mgorny @h-vetinari